feat: drop support for jest<27.2.5 #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: please migrate your projects to Jest 28.x or 27.x
noomorph
force-pushed
the
feat/drop-jest-26
branch
from
1690329
to
d059532
Compare
d4vidi
reviewed
May 23, 2022
| const FailingTestsReporter = require('./FailingTestsReporter'); | ||
|
|
||
| class DetoxReporter extends DetoxStreamlineJestReporter { | ||
| class DetoxReporter extends JestVerboseReporter { |
There was a problem hiding this comment.
OK, I looked into jest's new VerboseReporter and it seems like it is indeed now equivalent to DetoxStreamlineJestReporter ✅
+2 points to for being great visionaries
d4vidi
reviewed
May 23, 2022
|
|
||
| function assertSupportedVersion(actualVersion) { | ||
| const supportedRange = detoxPackageJson.peerDependencies.jest; | ||
| const minSupportedVersion = semver.minVersion(supportedRange); |
d4vidi
reviewed
May 23, 2022
| return maybeProjectConfig; | ||
| } | ||
|
|
||
| function assertSupportedVersion(actualVersion) { |
There was a problem hiding this comment.
On a nit-picky note related strictly to styling: Why have a specific function just for that last part (version assertion), and not for any of the preliminary assertions as well? 🤔
There was a problem hiding this comment.
You're right, it could have looked a bit better! 👍
noomorph
added a commit
that referenced
this pull request
Nov 10, 2022
* feat: set minimal Node requirement to 14.5.x * feat: drop old Jest integrations BREAKING CHANGE: please upgrade to jest-circus https://wix.github.io/Detox/docs/guide/jest/ * feat(config): drop default "e2e" value for specs (#3289) BREAKING CHANGE: Detox won't be appending "e2e" glob to the test runner if it is not explicitly configured to do so via "specs" property in the config. * feat(config): drop skipLegacyWorkersInjection (#3286) BREAKING CHANGE: Detox will no longer be injecting "-w 1" to Jest as CLI arguments * feat(android): boot read-only emulators by default * feat(iOS): support --headless config (#3304) BREAKING: opens Simulator app by default unless the headless mode is enabled * feat: drop Mocha support (#3310) BREAKING: Detox users should migrate to Jest * feat(android): remove deprecated native IdlePolicyConfig (#3332) BREAKING CHANGE * feat: drop device.appLaunchArgs [options] argument (#3360) BREAKING: use device.appLaunchArgs.shared for permanent operations * feat: remove ios.none device type (#3361) * feat: undeprecate device.relaunchApp() (#3362) * feat(config): remove legacy dash-based props (#3371) BREAKING: removes test-runner and runner-config props from Detox global config. Use testRunner and runnerConfig instead. * feat(config): drop support for the all-in-one configuration format (#3386) BREAKING: please migrate to the new { apps, devices, configurations } schema that Detox has been already using for more than a year. * feat: drop jest<27.2.5 support (#3392) BREAKING: please migrate your projects to Jest 28.x or 27.x * fix(ios): headless mode * feat: new global lifecycle for Detox (#3333) * fix(cli): forward env overrides anyway * feat(config): add testRunner.forwardEnv Also, fixes --inspect-brk debugging experience. Now the entire debug happens in a single test runner process. * feat(api): detoxInternals.tracing.createEventStream * feat(config): add reversePorts to app config (#3610) * fix(Android): pass `headless` config param to the AVD validator. (#3614) * feat(cli): add reset-lock-file command * website: add Showcase page * website: homepage changes * feat(cli): drop --device-launch-args arg (#3665) BREAKING: use --device-boot-args instead Co-authored-by: Asaf Korem <asaf.korem@gmail.com> Co-authored-by: d4vidi <amit.d4vidi@gmail.com> Co-authored-by: jasonbariwix <jasonba@wix.com> Co-authored-by: Yevheniia Hlovatska <33955728+evgeniyaglovatskaya@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3394